Page MenuHomePhabricator

Replace "DiffusionCommitListView" with "DiffusionCommitGraphView"
ClosedPublic

Authored by epriestley on Jul 12 2020, 3:41 PM.
Tags
None
Referenced Files
F19484375: D21412.id50956.diff
Thu, Jan 8, 2:15 AM
F19083359: D21412.id51029.diff
Dec 2 2025, 12:34 PM
F19083358: D21412.id50957.diff
Dec 2 2025, 12:34 PM
F19081211: D21412.id51029.diff
Dec 2 2025, 4:27 AM
F18993534: D21412.id50956.diff
Nov 19 2025, 8:10 AM
F18875487: D21412.id50956.diff
Nov 5 2025, 6:07 PM
F18837306: D21412.diff
Oct 27 2025, 4:51 AM
F18771507: D21412.id.diff
Oct 8 2025, 8:02 PM
Subscribers
None

Details

Summary

Ref T13552. This older view mostly duplicates other code and has only two callsites:

  • The "Commits" section of user profile pages.
  • The "Ambiguous Hash" page when you visit a commit hash page which is an ambiguous prefix of two or more commit hashes.

Replace both with "DiffusionCommitGraphView".

Test Plan
  • Visited profile page, clicked "Commits".
  • Visited an ambiguous hash page (rPbd3c23).

Diff Detail

Repository
rP Phabricator
Branch
publish9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24777
Build 34176: Run Core Tests
Build 34175: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 12 2020, 3:42 PM
Harbormaster failed remote builds in B24776: Diff 50956!
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:59 PM
This revision was automatically updated to reflect the committed changes.