Page MenuHomePhabricator

Replace "DiffusionCommitListView" with "DiffusionCommitGraphView"
ClosedPublic

Authored by epriestley on Jul 12 2020, 3:41 PM.
Tags
None
Referenced Files
F15458026: D21412.diff
Sun, Mar 30, 8:26 PM
F15442195: D21412.id.diff
Wed, Mar 26, 10:07 PM
F15440944: D21412.id51029.diff
Wed, Mar 26, 3:37 PM
F15438895: D21412.id50956.diff
Wed, Mar 26, 4:24 AM
F15435272: D21412.id50957.diff
Tue, Mar 25, 7:39 AM
F15433013: D21412.diff
Mon, Mar 24, 8:52 PM
F15432894: D21412.diff
Mon, Mar 24, 8:09 PM
F15429199: D21412.id51029.diff
Mon, Mar 24, 1:06 AM
Subscribers
None

Details

Summary

Ref T13552. This older view mostly duplicates other code and has only two callsites:

  • The "Commits" section of user profile pages.
  • The "Ambiguous Hash" page when you visit a commit hash page which is an ambiguous prefix of two or more commit hashes.

Replace both with "DiffusionCommitGraphView".

Test Plan
  • Visited profile page, clicked "Commits".
  • Visited an ambiguous hash page (rPbd3c23).

Diff Detail

Repository
rP Phabricator
Branch
publish9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24777
Build 34176: Run Core Tests
Build 34175: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 12 2020, 3:42 PM
Harbormaster failed remote builds in B24776: Diff 50956!
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:59 PM
This revision was automatically updated to reflect the committed changes.