Page MenuHomePhabricator

Replace "DiffusionCommitListView" with "DiffusionCommitGraphView"
ClosedPublic

Authored by epriestley on Jul 12 2020, 3:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 29, 3:06 PM
Unknown Object (File)
Mar 20 2024, 12:18 AM
Unknown Object (File)
Mar 15 2024, 8:01 PM
Unknown Object (File)
Feb 21 2024, 2:12 AM
Unknown Object (File)
Feb 19 2024, 7:47 AM
Unknown Object (File)
Jan 9 2024, 8:05 AM
Unknown Object (File)
Dec 27 2023, 2:49 PM
Unknown Object (File)
Dec 27 2023, 1:34 PM
Subscribers
None

Details

Summary

Ref T13552. This older view mostly duplicates other code and has only two callsites:

  • The "Commits" section of user profile pages.
  • The "Ambiguous Hash" page when you visit a commit hash page which is an ambiguous prefix of two or more commit hashes.

Replace both with "DiffusionCommitGraphView".

Test Plan
  • Visited profile page, clicked "Commits".
  • Visited an ambiguous hash page (rPbd3c23).

Diff Detail

Repository
rP Phabricator
Branch
publish9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24777
Build 34176: Run Core Tests
Build 34175: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 12 2020, 3:42 PM
Harbormaster failed remote builds in B24776: Diff 50956!
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:59 PM
This revision was automatically updated to reflect the committed changes.