Page MenuHomePhabricator
Differential D21412

Replace "DiffusionCommitListView" with "DiffusionCommitGraphView"
ClosedPublic
Actions

Authored by epriestley on Jul 12 2020, 3:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 15, 10:49 PM
Unknown Object (File)
Mon, Feb 10, 3:06 AM
Unknown Object (File)
Sun, Feb 9, 9:46 AM
Unknown Object (File)
Sun, Feb 9, 9:46 AM
Unknown Object (File)
Sun, Feb 9, 9:46 AM
Unknown Object (File)
Sun, Feb 9, 9:46 AM
Unknown Object (File)
Tue, Feb 4, 3:10 AM
Unknown Object (File)
Wed, Jan 29, 7:22 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits
rPcd09ba5e19d7: Replace "DiffusionCommitListView" with "DiffusionCommitGraphView"
Summary

Ref T13552. This older view mostly duplicates other code and has only two callsites:

  • The "Commits" section of user profile pages.
  • The "Ambiguous Hash" page when you visit a commit hash page which is an ambiguous prefix of two or more commit hashes.

Replace both with "DiffusionCommitGraphView".

Test Plan
  • Visited profile page, clicked "Commits".
  • Visited an ambiguous hash page (rPbd3c23).

Diff Detail

Repository
rP Phabricator
Branch
publish9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24777
Build 34176: Run Core Tests
Build 34175: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 12 2020, 3:41 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 12 2020, 3:42 PM
Harbormaster failed remote builds in B24776: Diff 50956!
epriestley updated this revision to Diff 50957.Jul 12 2020, 3:43 PM
  • Rebuild Celerity map.
Harbormaster completed remote builds in B24777: Diff 50957.Jul 12 2020, 3:44 PM
epriestley requested review of this revision.Jul 12 2020, 3:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:59 PM
Closed by commit rPcd09ba5e19d7: Replace "DiffusionCommitListView" with "DiffusionCommitGraphView" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPcd09ba5e19d7: Replace "DiffusionCommitListView" with "DiffusionCommitGraphView".

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
diffusion/
controller/
5 lines
21 lines
view/
21 lines
people/
controller/
6 lines
webroot/
rsrc/
css/
application/
diffusion/
8 lines

Diff 50957

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionHistoryController.php

Loading...
View Options

src/applications/diffusion/view/DiffusionCommitGraphView.php

Loading...
View Options

src/applications/diffusion/view/DiffusionCommitListView.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php

Loading...
View Options

webroot/rsrc/css/application/diffusion/diffusion.css

Loading...
Phabricator · Built by Phacility