Replace "DiffusionCommitListView" with "DiffusionCommitGraphView"
ClosedPublic
Actions

Authored by epriestley on Jul 12 2020, 3:41 PM.

Details

Reviewers: None
Maniphest Tasks: T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits: rPcd09ba5e19d7: Replace "DiffusionCommitListView" with "DiffusionCommitGraphView"

Summary

Ref T13552. This older view mostly duplicates other code and has only two callsites:

The "Commits" section of user profile pages.
The "Ambiguous Hash" page when you visit a commit hash page which is an ambiguous prefix of two or more commit hashes.

Replace both with "DiffusionCommitGraphView".

Test Plan

Visited profile page, clicked "Commits".
Visited an ambiguous hash page (rPbd3c23).

Diff Detail

Repository

rP Phabricator

Branch

publish9

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 24776
Build 34174: Run Core Tests
Build 34173: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	512 ms	PhabricatorLibraryTestCase::testEverythingImplemented EXCEPTION (Exception): Source file "/Users/epriestley/dev/core/lib/phabricator/src/applications/diffusion/view/DiffusionCommitListView.php" failed to load. #0 /Users/epriestley/dev/core/lib/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/Users/epriestl...') #1 /Users/epriestley/dev/core/lib/arcanist/src/symbols/PhutilSymbolLoader.php(422): PhutilBootloader->loadLibrarySource('phabricator', 'applications/di...')
	1,108 ms	PhabricatorLibraryTestCase::testEverythingImplemented EXCEPTION (Exception): Source file "/core/data/drydock/workingcopy-86/repo/phabricator/src/applications/diffusion/view/DiffusionCommitListView.php" failed to load. #0 /core/data/drydock/workingcopy-86/repo/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/core/data/dryd...') #1 /core/data/drydock/workingcopy-86/repo/arcanist/src/symbols/PhutilSymbolLoader.php(422): PhutilBootloader->loadLibrarySource('phabricator', 'applications/di...')
	370 ms	PhabricatorLibraryTestCase::testLibraryMap Assertion failed, expected 'true' (at PhutilLibraryTestCase.php:51): The library map is out of date. Rebuild it with `arc liberate`. These entries differ: class.DiffusionCommitListView, xmap.DiffusionCommitListView.
	1,201 ms	PhabricatorLibraryTestCase::testLibraryMap Assertion failed, expected 'true' (at PhutilLibraryTestCase.php:51): The library map is out of date. Rebuild it with `arc liberate`. These entries differ: class.DiffusionCommitListView, xmap.DiffusionCommitListView.
	109 ms	PhabricatorLibraryTestCase::testMethodVisibility EXCEPTION (Exception): Source file "/Users/epriestley/dev/core/lib/phabricator/src/applications/diffusion/view/DiffusionCommitListView.php" failed to load. #0 /Users/epriestley/dev/core/lib/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/Users/epriestl...') #1 /Users/epriestley/dev/core/lib/arcanist/src/symbols/PhutilSymbolLoader.php(422): PhutilBootloader->loadLibrarySource('phabricator', 'applications/di...')
		View Full Test Results (6 Failed · 419 Passed · 2 Skipped)