Page MenuHomePhabricator

Allow non-authors to "Request Review" of draft revisions
ClosedPublic

Authored by epriestley on Jul 9 2020, 9:10 PM.
Tags
None
Referenced Files
F13207075: D21403.id.diff
Wed, May 15, 8:58 PM
F13203990: D21403.id50943.diff
Wed, May 15, 12:16 AM
F13203381: D21403.diff
Tue, May 14, 11:41 PM
F13201589: D21403.id.diff
Tue, May 14, 1:20 PM
Unknown Object (File)
Apr 25 2024, 3:12 AM
Unknown Object (File)
Apr 24 2024, 9:21 PM
Unknown Object (File)
Apr 24 2024, 5:44 AM
Unknown Object (File)
Apr 20 2024, 5:25 PM
Subscribers
None

Details

Summary

See PHI1810. In situations where:

  • An author submits an urgent change for review.
  • The author pings reviewers to ask them to look at it.

...the reviewers may not be able to move the review forward if the review is currently a "Draft". They can only "Commandeer" or ask the author to "Request Review" as ways forward.

Although I'm hesitant to support review actions (particularly, "Accept") on draft revisions, I think there's no harm in allowing reviewers to skip tests and promote the revision out of draft as an explicit action.

Additionally, lightly specialize some of the transaction strings to distinguish between "request review from draft" and other state transitions.

Test Plan
  • As an author, used "Request Review" to promote a draft and to return a change to reviewers for consideration. These behaviors are unchanged, except "promote a draft" has different timeline text.
  • As a non-author, used "Begin Review" to promote a draft.

Diff Detail

Repository
rP Phabricator
Branch
request3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24762
Build 34151: Run Core Tests
Build 34150: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 9 2020, 9:20 PM
This revision was automatically updated to reflect the committed changes.