Page MenuHomePhabricator

Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't adding any non-you subscribers
ClosedPublic

Authored by epriestley on Jul 9 2020, 9:00 PM.
Tags
None
Referenced Files
F19075140: D21402.id50945.diff
Mon, Dec 1, 8:37 AM
F18811256: D21402.diff
Oct 20 2025, 2:18 AM
F18808698: D21402.id.diff
Oct 19 2025, 8:05 AM
F18805613: D21402.id50942.diff
Oct 18 2025, 3:58 PM
F18804969: D21402.diff
Oct 18 2025, 12:42 PM
F18750485: D21402.id.diff
Oct 4 2025, 7:58 AM
F18611896: D21402.id.diff
Sep 14 2025, 8:07 AM
F18601702: D21402.diff
Sep 13 2025, 1:14 PM
Subscribers
None

Details

Summary

Currently, adding subscribers to a draft revision raises a warning that they won't get an email/notification.

This warning has some false positives:

  • it triggers on any subscriber change, including removing subscribers; and
  • it triggers if you're only adding yourself as a subscriber.

Narrow the scope of the warning so it is raised only if you're adding a subscriber other than yourself.

Test Plan
  • Added a non-self subscriber, got the warning as before.
  • Added self as a subscriber, no warning (previously: warning).
  • Removed a subscriber, no warning (previously: warning).

Diff Detail

Repository
rP Phabricator
Branch
request2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24761
Build 34149: Run Core Tests
Build 34148: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 9 2020, 9:20 PM
This revision was automatically updated to reflect the committed changes.