Page MenuHomePhabricator

Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't adding any non-you subscribers

Authored by epriestley on Jul 9 2020, 9:00 PM.



Currently, adding subscribers to a draft revision raises a warning that they won't get an email/notification.

This warning has some false positives:

  • it triggers on any subscriber change, including removing subscribers; and
  • it triggers if you're only adding yourself as a subscriber.

Narrow the scope of the warning so it is raised only if you're adding a subscriber other than yourself.

Test Plan
  • Added a non-self subscriber, got the warning as before.
  • Added self as a subscriber, no warning (previously: warning).
  • Removed a subscriber, no warning (previously: warning).

Diff Detail

rP Phabricator
Lint OK
Unit Tests OK
Build Status
Buildable 24761
Build 34149: Run Core Tests
Build 34148: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 9 2020, 9:20 PM
This revision was automatically updated to reflect the committed changes.