Differential D21402

Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't adding any non-you subscribers
ClosedPublic
Actions

Authored by epriestley on Jul 9 2020, 9:00 PM.

Details

Reviewers: None
Commits: rP6e85b521fe86: Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't…

Summary

Currently, adding subscribers to a draft revision raises a warning that they won't get an email/notification.

This warning has some false positives:

it triggers on any subscriber change, including removing subscribers; and
it triggers if you're only adding yourself as a subscriber.

Narrow the scope of the warning so it is raised only if you're adding a subscriber other than yourself.

Test Plan

Added a non-self subscriber, got the warning as before.
Added self as a subscriber, no warning (previously: warning).
Removed a subscriber, no warning (previously: warning).

Diff Detail

Repository

rP Phabricator

Branch

request2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24761
Build 34149: Run Core Tests
Build 34148: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 9 2020, 9:00 PM

Harbormaster completed remote builds in B24761: Diff 50942.Jul 9 2020, 9:02 PM

epriestley requested review of this revision.Jul 9 2020, 9:02 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 9 2020, 9:20 PM

Closed by commit rP6e85b521fe86: Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP6e85b521fe86: Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't….

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

20 lines

Diff 50942

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't adding any non-you subscribersClosedPublicActions