Page MenuHomePhabricator
Differential D21395

Clean up push failure messaging in "arc land" slightly
ClosedPublic
Actions

Authored by epriestley on Jul 8 2020, 9:13 PM.
Tags
None
Referenced Files
F19827694: D21395.id50931.diff
Mon, Mar 9, 11:49 AM
F19826522: D21395.id50931.diff
Sun, Mar 8, 9:05 PM
F19822284: D21395.diff
Sat, Mar 7, 4:25 AM
F19816377: D21395.id.diff
Thu, Mar 5, 5:19 AM
F19816159: D21395.id.diff
Thu, Mar 5, 4:17 AM
F19772798: D21395.id.diff
Fri, Feb 20, 8:40 PM
F19772796: D21395.id.diff
Fri, Feb 20, 8:40 PM
F19766072: D21395.id50928.diff
Thu, Feb 19, 10:47 AM
View All Files
Subscribers
None

Details

Reviewers
None
Commits
rARC3633364bb96f: Clean up push failure messaging in "arc land" slightly
Summary

Ref PHI1808. Currently, push failures are messaged awkwardly. Make this exception handling more selective and the user-facing behavior more readable.

Test Plan

Ran "arc land" against a failing remote, saw a human-readable message instead of a stack trace.

Diff Detail

Repository
rARC Arcanist
Branch
hg6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24747
Build 34128: Run Core Tests
Build 34127: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 8 2020, 9:13 PM
Harbormaster completed remote builds in B24747: Diff 50928.Jul 8 2020, 9:14 PM
epriestley requested review of this revision.Jul 8 2020, 9:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 8 2020, 10:30 PM
Closed by commit rARC3633364bb96f: Clean up push failure messaging in "arc land" slightly (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC3633364bb96f: Clean up push failure messaging in "arc land" slightly.

Revision Contents
Changeset List

Diff 50928

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/land/engine/ArcanistGitLandEngine.php

Loading...
View Options

src/land/engine/ArcanistLandEngine.php

Loading...
View Options

src/land/engine/ArcanistMercurialLandEngine.php

Loading...
View Options

src/land/exception/ArcanistLandPushFailureException.php

Loading...
Phabricator · Built by Phacility