Page MenuHomePhabricator

Clean up push failure messaging in "arc land" slightly
ClosedPublic

Authored by epriestley on Jul 8 2020, 9:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 5 2025, 5:54 PM
Unknown Object (File)
Jun 5 2025, 5:02 PM
Unknown Object (File)
Jun 3 2025, 9:20 PM
Unknown Object (File)
May 18 2025, 8:59 PM
Unknown Object (File)
May 18 2025, 8:58 PM
Unknown Object (File)
May 18 2025, 8:57 PM
Unknown Object (File)
Apr 28 2025, 5:55 PM
Unknown Object (File)
Apr 27 2025, 9:38 PM
Subscribers
None

Details

Summary

Ref PHI1808. Currently, push failures are messaged awkwardly. Make this exception handling more selective and the user-facing behavior more readable.

Test Plan

Ran "arc land" against a failing remote, saw a human-readable message instead of a stack trace.

Diff Detail

Repository
rARC Arcanist
Branch
hg6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24747
Build 34128: Run Core Tests
Build 34127: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 8 2020, 10:30 PM
This revision was automatically updated to reflect the committed changes.