Page MenuHomePhabricator

Clean up push failure messaging in "arc land" slightly
ClosedPublic

Authored by epriestley on Jul 8 2020, 9:13 PM.
Tags
None
Referenced Files
F14761930: D21395.diff
Thu, Jan 23, 3:54 AM
Unknown Object (File)
Tue, Jan 21, 12:59 PM
Unknown Object (File)
Dec 9 2024, 1:05 PM
Unknown Object (File)
Nov 28 2024, 7:41 PM
Unknown Object (File)
Nov 26 2024, 9:44 PM
Unknown Object (File)
Nov 25 2024, 11:14 PM
Unknown Object (File)
Nov 20 2024, 7:04 AM
Unknown Object (File)
Oct 24 2024, 3:06 AM
Subscribers
None

Details

Summary

Ref PHI1808. Currently, push failures are messaged awkwardly. Make this exception handling more selective and the user-facing behavior more readable.

Test Plan

Ran "arc land" against a failing remote, saw a human-readable message instead of a stack trace.

Diff Detail

Repository
rARC Arcanist
Branch
hg6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24747
Build 34128: Run Core Tests
Build 34127: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 8 2020, 10:30 PM
This revision was automatically updated to reflect the committed changes.