Page MenuHomePhabricator

Clean up push failure messaging in "arc land" slightly
ClosedPublic

Authored by epriestley on Jul 8 2020, 9:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 30, 10:11 PM
Unknown Object (File)
Fri, Mar 29, 1:44 AM
Unknown Object (File)
Thu, Mar 28, 8:37 PM
Unknown Object (File)
Thu, Mar 28, 9:26 AM
Unknown Object (File)
Mar 5 2024, 4:19 PM
Unknown Object (File)
Feb 26 2024, 3:58 AM
Unknown Object (File)
Feb 25 2024, 5:31 PM
Unknown Object (File)
Feb 24 2024, 4:03 PM
Subscribers
None

Details

Summary

Ref PHI1808. Currently, push failures are messaged awkwardly. Make this exception handling more selective and the user-facing behavior more readable.

Test Plan

Ran "arc land" against a failing remote, saw a human-readable message instead of a stack trace.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 8 2020, 10:30 PM
This revision was automatically updated to reflect the committed changes.