Page MenuHomePhabricator
Differential D21373

Collapse repository URI normalization code into Arcanist
ClosedPublic
Actions

Authored by epriestley on Jun 30 2020, 5:55 PM.
Tags
None
Referenced Files
F15509559: D21373.id50896.diff
Wed, Apr 16, 2:02 PM
F15508287: D21373.diff
Wed, Apr 16, 4:09 AM
F15463446: D21373.id.diff
Tue, Apr 1, 11:35 PM
F15463445: D21373.id50896.diff
Tue, Apr 1, 11:35 PM
F15463444: D21373.id50875.diff
Tue, Apr 1, 11:34 PM
F15441632: D21373.id50875.diff
Wed, Mar 26, 6:59 PM
F15435545: D21373.id.diff
Tue, Mar 25, 8:50 AM
F15430240: D21373.diff
Mon, Mar 24, 6:40 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13546: Modernize the "arc land" workflow
Commits
rP7d496f2c6d7b: Collapse repository URI normalization code into Arcanist
Summary

Ref T13546. Companion change to D21372. Move URI normalization code to Arcanist to we can more-often resolve remote URIs correctly.

Test Plan

Grepped for affected symbols.

Diff Detail

Repository
rP Phabricator
Branch
urinormal2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24693
Build 34051: Run Core Tests
Build 34050: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 30 2020, 5:55 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 30 2020, 5:56 PM
Harbormaster failed remote builds in B24693: Diff 50875!
Harbormaster completed remote builds in B24693: Diff 50875.Jun 30 2020, 10:02 PM
epriestley requested review of this revision.Jun 30 2020, 10:02 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 30 2020, 10:54 PM
Closed by commit rP7d496f2c6d7b: Collapse repository URI normalization code into Arcanist (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP7d496f2c6d7b: Collapse repository URI normalization code into Arcanist.

Revision Contents
Changeset List

Diff 50875

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/repository/data/PhabricatorRepositoryURINormalizer.php

Loading...
View Options

src/applications/repository/data/__tests__/PhabricatorRepositoryURINormalizerTestCase.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryQuery.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryURI.php

Loading...
Phabricator · Built by Phacility