Page MenuHomePhabricator
Differential D21373

Collapse repository URI normalization code into Arcanist
ClosedPublic
Actions

Authored by epriestley on Jun 30 2020, 5:55 PM.
Tags
None
Referenced Files
F18784682: D21373.diff
Mon, Oct 13, 2:27 PM
F18611992: D21373.id.diff
Sep 14 2025, 8:14 AM
F18598711: D21373.diff
Sep 13 2025, 5:40 AM
F18396428: D21373.diff
Aug 29 2025, 12:16 PM
F18110510: D21373.id50896.diff
Aug 11 2025, 8:29 PM
F18110266: D21373.id50875.diff
Aug 11 2025, 5:51 PM
F18104039: D21373.id.diff
Aug 10 2025, 9:27 AM
F18101209: D21373.id.diff
Aug 9 2025, 12:22 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13546: Modernize the "arc land" workflow
Commits
rP7d496f2c6d7b: Collapse repository URI normalization code into Arcanist
Summary

Ref T13546. Companion change to D21372. Move URI normalization code to Arcanist to we can more-often resolve remote URIs correctly.

Test Plan

Grepped for affected symbols.

Diff Detail

Repository
rP Phabricator
Branch
urinormal2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24693
Build 34051: Run Core Tests
Build 34050: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 30 2020, 5:55 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 30 2020, 5:56 PM
Harbormaster failed remote builds in B24693: Diff 50875!
Harbormaster completed remote builds in B24693: Diff 50875.Jun 30 2020, 10:02 PM
epriestley requested review of this revision.Jun 30 2020, 10:02 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 30 2020, 10:54 PM
Closed by commit rP7d496f2c6d7b: Collapse repository URI normalization code into Arcanist (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP7d496f2c6d7b: Collapse repository URI normalization code into Arcanist.

Revision Contents
Changeset List

Diff 50875

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/repository/data/PhabricatorRepositoryURINormalizer.php

Loading...
View Options

src/applications/repository/data/__tests__/PhabricatorRepositoryURINormalizerTestCase.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryQuery.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryURI.php

Loading...
Phabricator · Built by Phacility