Remove implicit sorting from "MarkerRefQuery"
ClosedPublic
Actions

Authored by epriestley on Jun 17 2020, 5:31 PM.

Tags

None

Referenced Files

	F22829429: D21364.diff
	Sat, Oct 10, 11:47 PM

	F22713699: D21364.id50890.diff
	Sat, Oct 3, 3:53 PM

	F22605046: D21364.diff
	Mon, Sep 28, 9:35 PM

	Unknown Object (File)
	Sep 2 2026, 2:28 AM

	Unknown Object (File)
	Aug 26 2026, 9:45 AM

	Unknown Object (File)
	Jul 1 2026, 5:21 AM

	Unknown Object (File)
	Jun 22 2026, 1:04 PM

	Unknown Object (File)
	Jun 22 2026, 12:58 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13546: Modernize the "arc land" workflow
Commits: rARC10c4a551ae9d: Remove implicit sorting from "MarkerRefQuery"

Summary

Ref T13546. This is no longer necessary after the introduction of "msortv_natural()", which can handle natural string sorting.

Test Plan

Ran "arc branches", saw the same sorting applied.

Diff Detail

Repository

rARC Arcanist

Branch

landx12

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24671
Build 34019: Run Core Tests
Build 34018: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 17 2020, 5:31 PM

Harbormaster completed remote builds in B24671: Diff 50852.Jun 17 2020, 5:31 PM

epriestley requested review of this revision.Jun 17 2020, 5:31 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 30 2020, 10:50 PM

Closed by commit rARC10c4a551ae9d: Remove implicit sorting from "MarkerRefQuery" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC10c4a551ae9d: Remove implicit sorting from "MarkerRefQuery".

Revision Contents
Changeset List

Path

Size

src/

repository/

marker/

ArcanistRepositoryMarkerQuery.php

15 lines

Diff 50852

View Options

src/repository/marker/ArcanistRepositoryMarkerQuery.php

Remove implicit sorting from "MarkerRefQuery"ClosedPublicActions