Page MenuHomePhabricator
Differential D21364

Remove implicit sorting from "MarkerRefQuery"
ClosedPublic
Actions

Authored by epriestley on Jun 17 2020, 5:31 PM.
Tags
None
Referenced Files
F15520304: D21364.id50852.diff
Sun, Apr 20, 5:28 AM
F15497355: D21364.diff
Sun, Apr 13, 10:21 AM
F15481502: D21364.diff
Tue, Apr 8, 9:23 PM
F15481496: D21364.diff
Tue, Apr 8, 9:18 PM
F15481490: D21364.diff
Tue, Apr 8, 9:13 PM
F15481340: D21364.diff
Tue, Apr 8, 8:10 PM
F15481318: D21364.diff
Tue, Apr 8, 7:58 PM
F15480820: D21364.diff
Tue, Apr 8, 4:46 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13546: Modernize the "arc land" workflow
Commits
rARC10c4a551ae9d: Remove implicit sorting from "MarkerRefQuery"
Summary

Ref T13546. This is no longer necessary after the introduction of "msortv_natural()", which can handle natural string sorting.

Test Plan

Ran "arc branches", saw the same sorting applied.

Diff Detail

Repository
rARC Arcanist
Branch
landx12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24671
Build 34019: Run Core Tests
Build 34018: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 17 2020, 5:31 PM
Harbormaster completed remote builds in B24671: Diff 50852.Jun 17 2020, 5:31 PM
epriestley requested review of this revision.Jun 17 2020, 5:31 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 30 2020, 10:50 PM
Closed by commit rARC10c4a551ae9d: Remove implicit sorting from "MarkerRefQuery" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC10c4a551ae9d: Remove implicit sorting from "MarkerRefQuery".

Revision Contents
Changeset List

PathSize
src/
repository/
marker/
15 lines

Diff 50852

View Options

src/repository/marker/ArcanistRepositoryMarkerQuery.php

Loading...
Phabricator · Built by Phacility