Page MenuHomePhabricator

Realign "arc land" closed/published warning around more modern language
ClosedPublic

Authored by epriestley on Jun 10 2020, 4:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 8:04 AM
Unknown Object (File)
Oct 25 2024, 5:00 AM
Unknown Object (File)
Oct 24 2024, 10:36 AM
Unknown Object (File)
Oct 24 2024, 9:31 AM
Unknown Object (File)
Oct 23 2024, 10:15 AM
Unknown Object (File)
Oct 18 2024, 6:25 AM
Unknown Object (File)
Oct 9 2024, 1:33 PM
Unknown Object (File)
Oct 9 2024, 1:33 PM
Subscribers
None

Details

Summary

Ref T13546. The modern constant from the modern API method for this state is "published", and this more narrowly covers the desired behavior (notably, excluding "Abandoned" revisions).

Test Plan

Ran "arc land ... --revision X" where "X" is a published revision, got an appropriate prompt.

Diff Detail

Repository
rARC Arcanist
Branch
hg4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24630
Build 33955: Run Core Tests
Build 33954: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 10 2020, 5:27 PM
This revision was automatically updated to reflect the committed changes.