Page MenuHomePhabricator

Realign "arc land" closed/published warning around more modern language
ClosedPublic

Authored by epriestley on Jun 10 2020, 4:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 10:32 AM
Unknown Object (File)
Feb 19 2024, 6:23 PM
Unknown Object (File)
Feb 17 2024, 4:29 PM
Unknown Object (File)
Feb 17 2024, 2:19 PM
Unknown Object (File)
Feb 13 2024, 7:49 AM
Unknown Object (File)
Jan 11 2024, 12:38 AM
Unknown Object (File)
Dec 26 2023, 1:56 PM
Unknown Object (File)
Dec 18 2023, 6:01 PM
Subscribers
None

Details

Summary

Ref T13546. The modern constant from the modern API method for this state is "published", and this more narrowly covers the desired behavior (notably, excluding "Abandoned" revisions).

Test Plan

Ran "arc land ... --revision X" where "X" is a published revision, got an appropriate prompt.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 10 2020, 5:27 PM
This revision was automatically updated to reflect the committed changes.