Page MenuHomePhabricator

Format "arc land" passthru commands more nicely, and execute them from CWD
ClosedPublic

Authored by epriestley on Jun 7 2020, 8:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 11:42 AM
Unknown Object (File)
Mon, Jan 27, 5:20 PM
Unknown Object (File)
Mon, Jan 27, 10:23 AM
Unknown Object (File)
Sat, Jan 25, 8:07 AM
Unknown Object (File)
Sat, Jan 25, 8:06 AM
Unknown Object (File)
Sat, Jan 25, 8:06 AM
Unknown Object (File)
Thu, Jan 23, 5:28 PM
Unknown Object (File)
Tue, Jan 21, 10:22 AM
Subscribers
None

Details

Summary

Fixes T13380. Ref T13546. Use slightly nicer command formatting for passthru commands, to make it more obvious what's going on and which pieces of output are from "arc" vs various subcommands.

Also, execute repository API passthru commands from the working copy root. All other commands already did this, the older API just didn't support it.

Test Plan

Ran "arc land" in Git and Mercurial repositories, saw nicer output formatting.

Diff Detail

Repository
rARC Arcanist
Branch
land23
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/land/engine/ArcanistMercurialLandEngine.php:370XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24582
Build 33890: Run Core Tests
Build 33889: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:26 PM
This revision was automatically updated to reflect the committed changes.