Page MenuHomePhabricator
Differential D21330

Format "arc land" passthru commands more nicely, and execute them from CWD
ClosedPublic
Actions

Authored by epriestley on Jun 7 2020, 8:12 PM.
Tags
None
Referenced Files
F15500146: D21330.id50794.diff
Sun, Apr 13, 4:17 PM
F15497665: D21330.id50760.diff
Sun, Apr 13, 10:55 AM
F15497664: D21330.id50794.diff
Sun, Apr 13, 10:55 AM
F15497662: D21330.id.diff
Sun, Apr 13, 10:55 AM
F15497601: D21330.diff
Sun, Apr 13, 10:47 AM
F15442197: D21330.id50760.diff
Wed, Mar 26, 10:08 PM
F15434497: D21330.id50794.diff
Mar 25 2025, 4:07 AM
F15433880: D21330.diff
Mar 25 2025, 1:01 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13380: `git push` fatals when CWD does not exist
T13546: Modernize the "arc land" workflow
Commits
rARCf3f31155b761: Format "arc land" passthru commands more nicely, and execute them from CWD
Summary

Fixes T13380. Ref T13546. Use slightly nicer command formatting for passthru commands, to make it more obvious what's going on and which pieces of output are from "arc" vs various subcommands.

Also, execute repository API passthru commands from the working copy root. All other commands already did this, the older API just didn't support it.

Test Plan

Ran "arc land" in Git and Mercurial repositories, saw nicer output formatting.

Diff Detail

Repository
rARC Arcanist
Branch
land23
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/land/engine/ArcanistMercurialLandEngine.php:370XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24582
Build 33890: Run Core Tests
Build 33889: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 7 2020, 8:12 PM
Harbormaster completed remote builds in B24582: Diff 50760.Jun 7 2020, 8:12 PM
epriestley requested review of this revision.Jun 7 2020, 8:12 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:26 PM
Closed by commit rARCf3f31155b761: Format "arc land" passthru commands more nicely, and execute them from CWD (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARCf3f31155b761: Format "arc land" passthru commands more nicely, and execute them from CWD.

Revision Contents
Changeset List

Diff 50760

View Options

src/land/engine/ArcanistGitLandEngine.php

Loading...
View Options

src/land/engine/ArcanistLandEngine.php

Loading...
View Options

src/land/engine/ArcanistMercurialLandEngine.php

Loading...
View Options

src/repository/api/ArcanistGitAPI.php

Loading...
View Options

src/repository/api/ArcanistMercurialAPI.php

Loading...
View Options

src/repository/api/ArcanistRepositoryAPI.php

Loading...
View Options

src/toolset/command/ArcanistCommand.php

Loading...
Phabricator · Built by Phacility