Page MenuHomePhabricator
Differential D21328

Improve final messages under "arc land --hold"
ClosedPublic
Actions

Authored by epriestley on Jun 7 2020, 7:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 3:41 PM
Unknown Object (File)
Fri, Dec 20, 7:48 PM
Unknown Object (File)
Wed, Dec 18, 5:44 AM
Unknown Object (File)
Mon, Dec 9, 4:18 PM
Unknown Object (File)
Sun, Dec 8, 2:32 PM
Unknown Object (File)
Tue, Dec 3, 12:11 AM
Unknown Object (File)
Mon, Nov 25, 5:02 AM
Unknown Object (File)
Mon, Nov 25, 4:10 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13546: Modernize the "arc land" workflow
Commits
rARC4d61c005310e: Improve final messages under "arc land --hold"
Summary

Ref T13546. Update some of the "arc land --hold" behavior to be more functional/consistent with the updated workflow.

Test Plan

Ran "arc land --hold" under various conditions, got sensible forward/restore instructions.

Diff Detail

Repository
rARC Arcanist
Branch
land21
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/land/engine/ArcanistLandEngine.php:1328XHP16TODO Comment
Advicesrc/land/engine/ArcanistMercurialLandEngine.php:613XHP16TODO Comment
Advicesrc/repository/state/ArcanistMercurialLocalState.php:49XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24580
Build 33886: Run Core Tests
Build 33885: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 7 2020, 7:07 PM
Harbormaster completed remote builds in B24580: Diff 50758.Jun 7 2020, 7:07 PM
epriestley requested review of this revision.Jun 7 2020, 7:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:22 PM
Closed by commit rARC4d61c005310e: Improve final messages under "arc land --hold" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC4d61c005310e: Improve final messages under "arc land --hold".

Revision Contents
Changeset List

Diff 50758

View Options

src/land/engine/ArcanistGitLandEngine.php

Loading...
View Options

src/land/engine/ArcanistLandEngine.php

Loading...
View Options

src/land/engine/ArcanistMercurialLandEngine.php

Loading...
View Options

src/repository/state/ArcanistGitLocalState.php

Loading...
View Options

src/repository/state/ArcanistMercurialLocalState.php

Loading...
View Options

src/repository/state/ArcanistRepositoryLocalState.php

Loading...
View Options

src/xsprintf/tsprintf.php

Loading...
Phabricator · Built by Phacility