Page MenuHomePhabricator

When "arc" receives SIGWINCH or other signals during display of a prompt, recover
ClosedPublic

Authored by epriestley on Jun 5 2020, 11:07 PM.
Tags
None
Referenced Files
F15153037: D21317.diff
Mon, Feb 17, 10:41 PM
Unknown Object (File)
Wed, Feb 12, 8:55 PM
Unknown Object (File)
Wed, Feb 12, 8:55 PM
Unknown Object (File)
Wed, Feb 12, 12:42 AM
Unknown Object (File)
Sun, Feb 9, 9:27 AM
Unknown Object (File)
Sun, Feb 9, 9:27 AM
Unknown Object (File)
Sun, Feb 9, 9:27 AM
Unknown Object (File)
Tue, Jan 28, 12:49 AM
Subscribers
None

Details

Summary

Ref T13546. Resizing the terminal window to send SIGWINCH, or other signals, may interrupt "stream_select()" with an error which upgrades to a RuntimeException.

When "stream_select()" fails, continue and test the stream itself.

Test Plan

Waited for a prompt, resized the window. Before patch: SIGWINCH interruption. After patch: undisturbed prompt.

Diff Detail

Repository
rARC Arcanist
Branch
land14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24567
Build 33863: Run Core Tests
Build 33862: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 10:57 PM
This revision was automatically updated to reflect the committed changes.