When "arc" receives SIGWINCH or other signals during display of a prompt, recover
ClosedPublic
Actions

Authored by epriestley on Jun 5 2020, 11:07 PM.

Details

Reviewers: None
Maniphest Tasks: T13546: Modernize the "arc land" workflow
Commits: rARC3ed81d35a23a: When "arc" receives SIGWINCH or other signals during display of a prompt…

Summary

Ref T13546. Resizing the terminal window to send SIGWINCH, or other signals, may interrupt "stream_select()" with an error which upgrades to a RuntimeException.

When "stream_select()" fails, continue and test the stream itself.

Test Plan

Waited for a prompt, resized the window. Before patch: SIGWINCH interruption. After patch: undisturbed prompt.

Diff Detail

Repository

rARC Arcanist

Branch

land14

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24567
Build 33863: Run Core Tests
Build 33862: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 5 2020, 11:07 PM

Harbormaster completed remote builds in B24567: Diff 50745.Jun 5 2020, 11:07 PM

epriestley requested review of this revision.Jun 5 2020, 11:07 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 10:57 PM

Closed by commit rARC3ed81d35a23a: When "arc" receives SIGWINCH or other signals during display of a prompt… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC3ed81d35a23a: When "arc" receives SIGWINCH or other signals during display of a prompt….

Revision Contents
Changeset List

Path

Size

src/

toolset/

ArcanistPrompt.php

26 lines

Diff 50745

View Options

src/toolset/ArcanistPrompt.php

When "arc" receives SIGWINCH or other signals during display of a prompt, recoverClosedPublicActions