Page MenuHomePhabricator

When "arc" receives SIGWINCH or other signals during display of a prompt, recover
ClosedPublic

Authored by epriestley on Jun 5 2020, 11:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 3, 2:00 PM
Unknown Object (File)
Wed, Feb 28, 4:52 PM
Unknown Object (File)
Feb 19 2024, 3:17 AM
Unknown Object (File)
Feb 10 2024, 11:52 PM
Unknown Object (File)
Feb 2 2024, 9:23 AM
Unknown Object (File)
Jan 19 2024, 5:28 PM
Unknown Object (File)
Jan 11 2024, 12:39 AM
Unknown Object (File)
Jan 7 2024, 4:46 PM
Subscribers
None

Details

Summary

Ref T13546. Resizing the terminal window to send SIGWINCH, or other signals, may interrupt "stream_select()" with an error which upgrades to a RuntimeException.

When "stream_select()" fails, continue and test the stream itself.

Test Plan

Waited for a prompt, resized the window. Before patch: SIGWINCH interruption. After patch: undisturbed prompt.

Diff Detail

Repository
rARC Arcanist
Branch
land14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24567
Build 33863: Run Core Tests
Build 33862: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 10:57 PM
This revision was automatically updated to reflect the committed changes.