Ref T13513. Inline comment context information is somewhat expensive to construct and can be cached. Add a readthrough cache on top of it.
Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13513: Make schema changes to inlines to prepare for new inline features
- Commits
- rP5d0ae283a9ab: Put a readthrough cache in front of inline context construction
Loaded a source code changeset with many inline comments, used Darkconsole to inspect query activity. Saw caches get populated. Updated cache key, saw caches regenerate. Browsed Diffusion, nothing looked broken.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- inline13
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 24483 Build 33740: Run Core Tests Build 33739: arc lint + arc unit