Page MenuHomePhabricator

Put a readthrough cache in front of inline context construction
ClosedPublic

Authored by epriestley on May 20 2020, 5:37 PM.
Tags
None
Referenced Files
F17609881: D21279.diff
Wed, Jul 9, 7:03 AM
Unknown Object (File)
Wed, Jul 2, 11:30 PM
Unknown Object (File)
Wed, Jul 2, 6:16 PM
Unknown Object (File)
Wed, Jul 2, 5:58 AM
Unknown Object (File)
Jun 5 2025, 4:56 PM
Unknown Object (File)
May 31 2025, 6:30 AM
Unknown Object (File)
May 4 2025, 10:57 PM
Unknown Object (File)
Apr 30 2025, 3:37 AM
Subscribers
None

Details

Summary

Ref T13513. Inline comment context information is somewhat expensive to construct and can be cached. Add a readthrough cache on top of it.

Test Plan

Loaded a source code changeset with many inline comments, used Darkconsole to inspect query activity. Saw caches get populated. Updated cache key, saw caches regenerate. Browsed Diffusion, nothing looked broken.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2020, 9:28 PM
This revision was automatically updated to reflect the committed changes.