Page MenuHomePhabricator
Differential D21279

Put a readthrough cache in front of inline context construction
ClosedPublic
Actions

Authored by epriestley on May 20 2020, 5:37 PM.
Tags
None
Referenced Files
F17636358: D21279.id.diff
Fri, Jul 11, 10:51 AM
F17609881: D21279.diff
Wed, Jul 9, 7:03 AM
Unknown Object (File)
Wed, Jul 2, 11:30 PM
Unknown Object (File)
Wed, Jul 2, 6:16 PM
Unknown Object (File)
Wed, Jul 2, 5:58 AM
Unknown Object (File)
Jun 5 2025, 4:56 PM
Unknown Object (File)
May 31 2025, 6:30 AM
Unknown Object (File)
May 4 2025, 10:57 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rP5d0ae283a9ab: Put a readthrough cache in front of inline context construction
Summary

Ref T13513. Inline comment context information is somewhat expensive to construct and can be cached. Add a readthrough cache on top of it.

Test Plan

Loaded a source code changeset with many inline comments, used Darkconsole to inspect query activity. Saw caches get populated. Updated cache key, saw caches regenerate. Browsed Diffusion, nothing looked broken.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 20 2020, 5:37 PM
Harbormaster completed remote builds in B24483: Diff 50664.May 20 2020, 5:38 PM
epriestley requested review of this revision.May 20 2020, 5:38 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 20 2020, 9:28 PM
Closed by commit rP5d0ae283a9ab: Put a readthrough cache in front of inline context construction (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP5d0ae283a9ab: Put a readthrough cache in front of inline context construction.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
query/
21 lines
diffusion/
query/
4 lines
infrastructure/
diff/
inline/
20 lines
interface/
10 lines
query/
78 lines

Diff 50673

View Options

src/applications/differential/query/DifferentialDiffInlineCommentQuery.php

Loading...
View Options

src/applications/diffusion/query/DiffusionDiffInlineCommentQuery.php

Loading...
View Options

src/infrastructure/diff/inline/PhabricatorDiffInlineCommentContext.php

Loading...
View Options

src/infrastructure/diff/interface/PhabricatorInlineComment.php

Loading...
View Options

src/infrastructure/diff/query/PhabricatorDiffInlineCommentQuery.php

Loading...
Phabricator · Built by Phacility