Page MenuHomePhabricator

Put a readthrough cache in front of inline context construction
ClosedPublic

Authored by epriestley on May 20 2020, 5:37 PM.

Details

Summary

Ref T13513. Inline comment context information is somewhat expensive to construct and can be cached. Add a readthrough cache on top of it.

Test Plan

Loaded a source code changeset with many inline comments, used Darkconsole to inspect query activity. Saw caches get populated. Updated cache key, saw caches regenerate. Browsed Diffusion, nothing looked broken.

Diff Detail

Repository
rP Phabricator
Branch
inline13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24483
Build 33740: Run Core Tests
Build 33739: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2020, 9:28 PM
This revision was automatically updated to reflect the committed changes.