Page MenuHomePhabricator

Update out-of-date API calls when rendering diffs inline in email
ClosedPublic

Authored by epriestley on May 19 2020, 5:31 PM.
Tags
None
Referenced Files
F19824611: D21270.id50650.diff
Sun, Mar 8, 1:22 AM
F19822058: D21270.diff
Sat, Mar 7, 2:28 AM
F19819618: D21270.id.diff
Fri, Mar 6, 7:49 AM
F18936351: D21270.diff
Nov 10 2025, 8:06 PM
F18854753: D21270.id.diff
Nov 1 2025, 12:35 AM
F18806435: D21270.id50652.diff
Oct 18 2025, 7:29 PM
F18797364: D21270.diff
Oct 17 2025, 4:58 AM
F18734298: D21270.diff
Sep 30 2025, 10:51 PM
Subscribers
None

Details

Summary

See PHI1745. This callsite for "ChangesetParser" was not properly updated for recent changes.

Test Plan
  • Set metamta.differential.inline-patches to 100.
  • Created a new revision with a small (<100 line) diff, with at least one reviewer.
  • Ran bin/phd debug and observed outbound mail queue with bin/mail list-outbound.
  • Before: fatal when trying to generate the inline changes for mail.
  • After: clean mail generation.

Diff Detail

Repository
rP Phabricator
Branch
inlinediff
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24469
Build 33717: Run Core Tests
Build 33716: arc lint + arc unit