Page MenuHomePhabricator

Update out-of-date API calls when rendering diffs inline in email
ClosedPublic

Authored by epriestley on May 19 2020, 5:31 PM.
Tags
None
Referenced Files
F13046163: D21270.diff
Thu, Apr 18, 7:12 AM
Unknown Object (File)
Fri, Apr 12, 12:12 AM
Unknown Object (File)
Thu, Apr 11, 8:31 AM
Unknown Object (File)
Sun, Mar 24, 8:28 PM
Unknown Object (File)
Sat, Mar 23, 9:45 PM
Unknown Object (File)
Mar 15 2024, 8:01 AM
Unknown Object (File)
Feb 24 2024, 4:54 PM
Unknown Object (File)
Feb 7 2024, 10:34 AM
Subscribers
None

Details

Summary

See PHI1745. This callsite for "ChangesetParser" was not properly updated for recent changes.

Test Plan
  • Set metamta.differential.inline-patches to 100.
  • Created a new revision with a small (<100 line) diff, with at least one reviewer.
  • Ran bin/phd debug and observed outbound mail queue with bin/mail list-outbound.
  • Before: fatal when trying to generate the inline changes for mail.
  • After: clean mail generation.

Diff Detail

Repository
rP Phabricator
Branch
inlinediff
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24469
Build 33717: Run Core Tests
Build 33716: arc lint + arc unit