Page MenuHomePhabricator

Update out-of-date API calls when rendering diffs inline in email
ClosedPublic

Authored by epriestley on May 19 2020, 5:31 PM.

Details

Summary

See PHI1745. This callsite for "ChangesetParser" was not properly updated for recent changes.

Test Plan
  • Set metamta.differential.inline-patches to 100.
  • Created a new revision with a small (<100 line) diff, with at least one reviewer.
  • Ran bin/phd debug and observed outbound mail queue with bin/mail list-outbound.
  • Before: fatal when trying to generate the inline changes for mail.
  • After: clean mail generation.

Diff Detail

Repository
rP Phabricator
Branch
inlinediff
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24469
Build 33717: Run Core Tests
Build 33716: arc lint + arc unit