Page MenuHomePhabricator

Allow construction of a ConduitEngine with a bare ConduitClient
ClosedPublic

Authored by epriestley on May 15 2020, 3:23 PM.
Tags
None
Referenced Files
F15472993: D21260.id50624.diff
Sat, Apr 5, 6:28 PM
F15461488: D21260.id.diff
Tue, Apr 1, 8:39 AM
F15457313: D21260.diff
Sun, Mar 30, 3:34 PM
F15457046: D21260.diff
Sun, Mar 30, 1:58 PM
F15435839: D21260.id.diff
Tue, Mar 25, 10:30 AM
F15332412: D21260.diff
Fri, Mar 7, 5:22 PM
Unknown Object (File)
Feb 9 2025, 9:19 AM
Unknown Object (File)
Feb 9 2025, 9:19 AM
Subscribers
None

Details

Summary

See PHI1735. "ConduitEngine" was once a future pool, but this has moved to "HardpointEngine". This class may no longer make much sense.

In Phacility code, "bin/host upload" depends on using the Uploader, which needs a "ConduitEngine", not a "ConduitClient". This workflow may use asymmetric key signing, which "ConduitEngine" does not support.

To unblock PHI1735, provide glue code between "Client" and "Engine". But a "more correct" change is probably removal of "Engine".

Test Plan
  • Ran bin/host upload, uploaded files (with additional changes to wrap the Client).
  • Created this revision.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 15 2020, 3:24 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.