Allow construction of a ConduitEngine with a bare ConduitClient
ClosedPublic
Actions

Authored by epriestley on May 15 2020, 3:23 PM.

Details

Reviewers: None
Commits: rARCbee3bc0570a3: (stable) Allow construction of a ConduitEngine with a bare ConduitClient
rARCe3030ebcad53: Allow construction of a ConduitEngine with a bare ConduitClient

Summary

See PHI1735. "ConduitEngine" was once a future pool, but this has moved to "HardpointEngine". This class may no longer make much sense.

In Phacility code, "bin/host upload" depends on using the Uploader, which needs a "ConduitEngine", not a "ConduitClient". This workflow may use asymmetric key signing, which "ConduitEngine" does not support.

To unblock PHI1735, provide glue code between "Client" and "Engine". But a "more correct" change is probably removal of "Engine".

Test Plan

Ran bin/host upload, uploaded files (with additional changes to wrap the Client).
Created this revision.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 15 2020, 3:23 PM

Harbormaster completed remote builds in B24441: Diff 50624.May 15 2020, 3:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 15 2020, 3:24 PM

epriestley requested review of this revision.

Closed by commit rARCe3030ebcad53: Allow construction of a ConduitEngine with a bare ConduitClient (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCe3030ebcad53: Allow construction of a ConduitEngine with a bare ConduitClient.

epriestley added a commit: rARCbee3bc0570a3: (stable) Allow construction of a ConduitEngine with a bare ConduitClient.

Revision Contents
Changeset List

Path

Size

src/

conduit/

ArcanistConduitEngine.php

14 lines

Diff 50625

View Options

src/conduit/ArcanistConduitEngine.php

Allow construction of a ConduitEngine with a bare ConduitClientClosedPublicActions