Page MenuHomePhabricator

Allow construction of a ConduitEngine with a bare ConduitClient
ClosedPublic

Authored by epriestley on May 15 2020, 3:23 PM.
Tags
None
Referenced Files
F13093022: D21260.diff
Thu, Apr 25, 6:28 AM
F13088966: D21260.diff
Thu, Apr 25, 1:37 AM
Unknown Object (File)
Sat, Apr 20, 5:15 PM
Unknown Object (File)
Thu, Apr 11, 9:20 AM
Unknown Object (File)
Sat, Apr 6, 2:03 AM
Unknown Object (File)
Mar 25 2024, 4:23 AM
Unknown Object (File)
Mar 24 2024, 8:16 AM
Unknown Object (File)
Mar 23 2024, 1:32 AM
Subscribers
None

Details

Summary

See PHI1735. "ConduitEngine" was once a future pool, but this has moved to "HardpointEngine". This class may no longer make much sense.

In Phacility code, "bin/host upload" depends on using the Uploader, which needs a "ConduitEngine", not a "ConduitClient". This workflow may use asymmetric key signing, which "ConduitEngine" does not support.

To unblock PHI1735, provide glue code between "Client" and "Engine". But a "more correct" change is probably removal of "Engine".

Test Plan
  • Ran bin/host upload, uploaded files (with additional changes to wrap the Client).
  • Created this revision.

Diff Detail

Repository
rARC Arcanist
Branch
client1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24441
Build 33679: Run Core Tests
Build 33678: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 15 2020, 3:24 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.