Page MenuHomePhabricator

When an inline was left on a rendered DocumentEngine document, don't include an email context patch
ClosedPublic

Authored by epriestley on May 12 2020, 9:09 PM.
Tags
None
Referenced Files
F14895606: D21242.id50589.diff
Sun, Feb 9, 9:16 AM
F14895605: D21242.id50586.diff
Sun, Feb 9, 9:16 AM
F14895604: D21242.id.diff
Sun, Feb 9, 9:16 AM
Unknown Object (File)
Sat, Feb 8, 7:46 AM
Unknown Object (File)
Sat, Feb 1, 11:49 PM
Unknown Object (File)
Sat, Jan 25, 7:38 AM
Unknown Object (File)
Sat, Jan 25, 7:38 AM
Unknown Object (File)
Sat, Jan 25, 7:38 AM
Subscribers
None

Details

Summary

Ref T13513. If you leave an inline on line 20 of a Jupyter document, we currently render context around *raw* line 20, which is inevitably some unrelated piece of JSON.

Instead, drop this context. (Ideal behavior would be to render context around Jupyter block 20, but that's a whole lot of work.)

Test Plan
  • On Jupyter changes and normal source changes, made and submitted inline comments, then viewed text and HTML mail.
  • Saw no context on Jupyter comments (instead of bad context), and unchanged behavior (useful context) on normal source changes.

Diff Detail

Repository
rP Phabricator
Branch
engine3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24403
Build 33623: Run Core Tests
Build 33622: arc lint + arc unit