Page MenuHomePhabricator

When an inline was left on a rendered DocumentEngine document, don't include an email context patch
ClosedPublic

Authored by epriestley on May 12 2020, 9:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 9 2024, 8:09 AM
Unknown Object (File)
Jan 5 2024, 7:13 PM
Unknown Object (File)
Dec 29 2023, 5:29 PM
Unknown Object (File)
Dec 23 2023, 10:07 PM
Unknown Object (File)
Dec 18 2023, 8:34 AM
Unknown Object (File)
Dec 12 2023, 9:53 PM
Unknown Object (File)
Nov 29 2023, 11:31 PM
Unknown Object (File)
Nov 25 2023, 11:29 PM
Subscribers
None

Details

Summary

Ref T13513. If you leave an inline on line 20 of a Jupyter document, we currently render context around *raw* line 20, which is inevitably some unrelated piece of JSON.

Instead, drop this context. (Ideal behavior would be to render context around Jupyter block 20, but that's a whole lot of work.)

Test Plan
  • On Jupyter changes and normal source changes, made and submitted inline comments, then viewed text and HTML mail.
  • Saw no context on Jupyter comments (instead of bad context), and unchanged behavior (useful context) on normal source changes.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable