Page MenuHomePhabricator

When an inline was left on a rendered DocumentEngine document, don't include an email context patch
ClosedPublic

Authored by epriestley on May 12 2020, 9:09 PM.
Tags
None
Referenced Files
F15511770: D21242.id50586.diff
Thu, Apr 17, 5:24 AM
F15501067: D21242.diff
Sun, Apr 13, 8:32 PM
F15463670: D21242.diff
Wed, Apr 2, 2:08 AM
F15456966: D21242.id50589.diff
Sun, Mar 30, 1:21 PM
F15456578: D21242.id50586.diff
Sun, Mar 30, 10:37 AM
F15455245: D21242.id.diff
Sat, Mar 29, 11:05 PM
F15451838: D21242.diff
Sat, Mar 29, 12:04 AM
Unknown Object (File)
Feb 24 2025, 2:43 AM
Subscribers
None

Details

Summary

Ref T13513. If you leave an inline on line 20 of a Jupyter document, we currently render context around *raw* line 20, which is inevitably some unrelated piece of JSON.

Instead, drop this context. (Ideal behavior would be to render context around Jupyter block 20, but that's a whole lot of work.)

Test Plan
  • On Jupyter changes and normal source changes, made and submitted inline comments, then viewed text and HTML mail.
  • Saw no context on Jupyter comments (instead of bad context), and unchanged behavior (useful context) on normal source changes.

Diff Detail

Repository
rP Phabricator
Branch
engine3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24403
Build 33623: Run Core Tests
Build 33622: arc lint + arc unit