Page MenuHomePhabricator

Persist "Show Changeset" and improve path text selection
ClosedPublic

Authored by epriestley on May 8 2020, 1:39 PM.
Tags
None
Referenced Files
F13202396: D21236.diff
Tue, May 14, 10:36 PM
F13184988: D21236.diff
Sat, May 11, 2:17 AM
Unknown Object (File)
Thu, May 2, 6:23 AM
Unknown Object (File)
Wed, May 1, 7:42 PM
Unknown Object (File)
Mon, Apr 29, 6:35 AM
Unknown Object (File)
Thu, Apr 25, 1:20 AM
Unknown Object (File)
Jan 16 2024, 2:23 AM
Unknown Object (File)
Jan 9 2024, 8:10 AM
Subscribers
None

Details

Summary

Ref T13513. Currently:

  • If you click the "Show Changeset" button, your state change doesn't actually get saved on the server.
  • It's hard to select a changeset path name for copy/paste because the "highlight the header" code tends to eat the event.

Instead: persist the former event; make the actual path text not be part of the highlight hitbox.

Test Plan
  • Clicked "Show Changeset", reloaded, saw changeset visibility persisted.
  • Selected changeset path text without issues.
  • Clicked non-text header area to select/deselect changesets.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 1:59 PM
This revision was automatically updated to reflect the committed changes.