Page MenuHomePhabricator

Persist "Show Changeset" and improve path text selection
ClosedPublic

Authored by epriestley on May 8 2020, 1:39 PM.
Tags
None
Referenced Files
F14120265: D21236.diff
Fri, Nov 29, 8:06 AM
F14118917: D21236.id50572.diff
Fri, Nov 29, 1:55 AM
F14118035: D21236.diff
Thu, Nov 28, 9:40 PM
Unknown Object (File)
Tue, Nov 26, 4:17 PM
Unknown Object (File)
Sun, Nov 24, 10:24 PM
Unknown Object (File)
Sat, Nov 23, 10:17 AM
Unknown Object (File)
Fri, Nov 22, 6:43 PM
Unknown Object (File)
Wed, Nov 20, 6:07 PM
Subscribers
None

Details

Summary

Ref T13513. Currently:

  • If you click the "Show Changeset" button, your state change doesn't actually get saved on the server.
  • It's hard to select a changeset path name for copy/paste because the "highlight the header" code tends to eat the event.

Instead: persist the former event; make the actual path text not be part of the highlight hitbox.

Test Plan
  • Clicked "Show Changeset", reloaded, saw changeset visibility persisted.
  • Selected changeset path text without issues.
  • Clicked non-text header area to select/deselect changesets.

Diff Detail

Repository
rP Phabricator
Branch
inline2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24388
Build 33601: Run Core Tests
Build 33600: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 1:59 PM
This revision was automatically updated to reflect the committed changes.