Page MenuHomePhabricator

Persist "Show Changeset" and improve path text selection
ClosedPublic

Authored by epriestley on May 8 2020, 1:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 16 2024, 2:23 AM
Unknown Object (File)
Jan 9 2024, 8:10 AM
Unknown Object (File)
Jan 5 2024, 1:23 PM
Unknown Object (File)
Dec 28 2023, 9:59 PM
Unknown Object (File)
Dec 27 2023, 1:24 PM
Unknown Object (File)
Dec 26 2023, 8:32 AM
Unknown Object (File)
Dec 25 2023, 10:22 PM
Unknown Object (File)
Dec 23 2023, 3:13 PM
Subscribers
None

Details

Summary

Ref T13513. Currently:

  • If you click the "Show Changeset" button, your state change doesn't actually get saved on the server.
  • It's hard to select a changeset path name for copy/paste because the "highlight the header" code tends to eat the event.

Instead: persist the former event; make the actual path text not be part of the highlight hitbox.

Test Plan
  • Clicked "Show Changeset", reloaded, saw changeset visibility persisted.
  • Selected changeset path text without issues.
  • Clicked non-text header area to select/deselect changesets.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 1:59 PM
This revision was automatically updated to reflect the committed changes.