Page MenuHomePhabricator

Persist "Show Changeset" and improve path text selection
ClosedPublic

Authored by epriestley on May 8 2020, 1:39 PM.
Tags
None
Referenced Files
F15411250: D21236.diff
Wed, Mar 19, 8:56 AM
F15411179: D21236.diff
Wed, Mar 19, 8:53 AM
F15411043: D21236.diff
Wed, Mar 19, 8:48 AM
F15410130: D21236.diff
Wed, Mar 19, 6:48 AM
F15379318: D21236.id50572.diff
Thu, Mar 13, 8:12 PM
F15343843: D21236.diff
Mon, Mar 10, 1:13 AM
F15335707: D21236.id50572.diff
Sat, Mar 8, 5:25 PM
F15332004: D21236.diff
Fri, Mar 7, 3:56 PM
Subscribers
None

Details

Summary

Ref T13513. Currently:

  • If you click the "Show Changeset" button, your state change doesn't actually get saved on the server.
  • It's hard to select a changeset path name for copy/paste because the "highlight the header" code tends to eat the event.

Instead: persist the former event; make the actual path text not be part of the highlight hitbox.

Test Plan
  • Clicked "Show Changeset", reloaded, saw changeset visibility persisted.
  • Selected changeset path text without issues.
  • Clicked non-text header area to select/deselect changesets.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 1:59 PM
This revision was automatically updated to reflect the committed changes.