Page MenuHomePhabricator
Differential D21235

Lift inline comment draft behaviors to "InlineController"
ClosedPublic
Actions

Authored by epriestley on May 8 2020, 1:26 PM.
Tags
None
Referenced Files
F13157663: D21235.id50571.diff
Sun, May 5, 1:22 PM
Unknown Object (File)
Fri, May 3, 6:13 AM
Unknown Object (File)
Wed, May 1, 2:49 AM
Unknown Object (File)
Sat, Apr 27, 10:41 PM
Unknown Object (File)
Thu, Apr 25, 1:06 AM
Unknown Object (File)
Thu, Apr 25, 1:03 AM
Unknown Object (File)
Sun, Apr 14, 9:24 PM
Unknown Object (File)
Thu, Apr 11, 8:45 AM
View All 59 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rPfa2d30ee3698: Lift inline comment draft behaviors to "InlineController"
Summary

Ref T13513. Currently, if you:

  • click a line to create an inline;
  • type some text;
  • wait a moment; and
  • close the page.

...you don't get an "Unsubmitted Draft" marker in the revision list.

Lift all the draft behavior to "InlineController" and make saving a draft dirty the overall container draft state.

Test Plan
  • Took the steps described above, got a draft state marker.
  • Created, edited, submitted, etc., inlines in Diffusion and Differential.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 8 2020, 1:26 PM
Harbormaster completed remote builds in B24387: Diff 50571.May 8 2020, 1:27 PM
epriestley requested review of this revision.May 8 2020, 1:27 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 1:52 PM
Closed by commit rPfa2d30ee3698: Lift inline comment draft behaviors to "InlineController" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPfa2d30ee3698: Lift inline comment draft behaviors to "InlineController".

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
36 lines
engine/
1 line
diffusion/
controller/
17 lines
engine/
1 line
infrastructure/
diff/
125 lines

Diff 50573

View Options

src/applications/differential/controller/DifferentialInlineCommentEditController.php

Loading...
View Options

src/applications/differential/engine/DifferentialRevisionDraftEngine.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionInlineCommentController.php

Loading...
View Options

src/applications/diffusion/engine/DiffusionCommitDraftEngine.php

Loading...
View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...
Phabricator · Built by Phacility