Page MenuHomePhabricator

Lift inline comment draft behaviors to "InlineController"
ClosedPublic

Authored by epriestley on May 8 2020, 1:26 PM.
Tags
None
Referenced Files
F14081193: D21235.id50571.diff
Fri, Nov 22, 6:44 PM
Unknown Object (File)
Thu, Nov 21, 3:36 AM
Unknown Object (File)
Sun, Nov 17, 12:37 PM
Unknown Object (File)
Sun, Nov 17, 2:54 AM
Unknown Object (File)
Wed, Nov 13, 5:24 PM
Unknown Object (File)
Tue, Oct 29, 9:14 PM
Unknown Object (File)
Thu, Oct 24, 3:51 PM
Unknown Object (File)
Oct 19 2024, 9:59 PM
Subscribers
None

Details

Summary

Ref T13513. Currently, if you:

  • click a line to create an inline;
  • type some text;
  • wait a moment; and
  • close the page.

...you don't get an "Unsubmitted Draft" marker in the revision list.

Lift all the draft behavior to "InlineController" and make saving a draft dirty the overall container draft state.

Test Plan
  • Took the steps described above, got a draft state marker.
  • Created, edited, submitted, etc., inlines in Diffusion and Differential.

Diff Detail

Repository
rP Phabricator
Branch
inline1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24387
Build 33599: Run Core Tests
Build 33598: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 1:52 PM
This revision was automatically updated to reflect the committed changes.