Page MenuHomePhabricator

Lift inline comment draft behaviors to "InlineController"
ClosedPublic

Authored by epriestley on May 8 2020, 1:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 2:19 AM
Unknown Object (File)
Feb 16 2024, 9:43 PM
Unknown Object (File)
Jan 31 2024, 3:45 AM
Unknown Object (File)
Jan 23 2024, 9:27 AM
Unknown Object (File)
Jan 22 2024, 3:14 AM
Unknown Object (File)
Dec 25 2023, 7:35 AM
Unknown Object (File)
Dec 25 2023, 2:28 AM
Unknown Object (File)
Dec 24 2023, 12:55 AM
Subscribers
None

Details

Summary

Ref T13513. Currently, if you:

  • click a line to create an inline;
  • type some text;
  • wait a moment; and
  • close the page.

...you don't get an "Unsubmitted Draft" marker in the revision list.

Lift all the draft behavior to "InlineController" and make saving a draft dirty the overall container draft state.

Test Plan
  • Took the steps described above, got a draft state marker.
  • Created, edited, submitted, etc., inlines in Diffusion and Differential.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 1:52 PM
This revision was automatically updated to reflect the committed changes.