Page MenuHomePhabricator

Persist "Show Changeset" and improve path text selection
ClosedPublic

Authored by epriestley on May 8 2020, 1:39 PM.
Tags
None
Referenced Files
F15458060: D21236.id50572.diff
Sun, Mar 30, 8:32 PM
F15455460: D21236.id.diff
Sun, Mar 30, 12:33 AM
F15450738: D21236.diff
Fri, Mar 28, 5:52 PM
F15434224: D21236.id50572.diff
Tue, Mar 25, 2:43 AM
F15434214: D21236.diff
Tue, Mar 25, 2:42 AM
F15427294: D21236.id50574.diff
Sun, Mar 23, 1:34 PM
F15424335: D21236.diff
Sat, Mar 22, 9:34 PM
F15411250: D21236.diff
Wed, Mar 19, 8:56 AM
Subscribers
None

Details

Summary

Ref T13513. Currently:

  • If you click the "Show Changeset" button, your state change doesn't actually get saved on the server.
  • It's hard to select a changeset path name for copy/paste because the "highlight the header" code tends to eat the event.

Instead: persist the former event; make the actual path text not be part of the highlight hitbox.

Test Plan
  • Clicked "Show Changeset", reloaded, saw changeset visibility persisted.
  • Selected changeset path text without issues.
  • Clicked non-text header area to select/deselect changesets.

Diff Detail

Repository
rP Phabricator
Branch
inline2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24388
Build 33601: Run Core Tests
Build 33600: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 1:59 PM
This revision was automatically updated to reflect the committed changes.