Page MenuHomePhabricator

Fix an issue where non-ID changeset state keys were used as changeset IDs
ClosedPublic

Authored by epriestley on May 4 2020, 11:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 29, 10:49 AM
Unknown Object (File)
Sat, Jun 28, 8:59 AM
Unknown Object (File)
Fri, Jun 27, 8:36 PM
Unknown Object (File)
Sun, Jun 15, 10:10 AM
Unknown Object (File)
May 30 2025, 9:45 AM
Unknown Object (File)
May 29 2025, 9:38 AM
Unknown Object (File)
May 28 2025, 10:32 AM
Unknown Object (File)
May 27 2025, 8:04 PM
Subscribers
None

Details

Summary

Ref T13519. This is a little fuzzy, but I think the workflow here is:

  • View an intradiff, generating an ephemeral comparison changeset with no changeset ID. This produces a state key of "*".
  • Apply "hidden" state changes to the changeset.
  • View some other intradiff and/or diff view.
  • The code attempts to use "*" as a changset ID?

I'm not entirely sure this is accurate; this was observed in production and I couldn't get a clean reproduction case locally.

Optimistically, try making changeset IDs explicit rather than relying on state keys to be "usually changeset-ID-like".

Test Plan

Used "hidden" locally across multiple intradiffs, but I wasn't cleanly able to reproduce the initial issue.

Diff Detail

Repository
rP Phabricator
Branch
changeset1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24361
Build 33560: Run Core Tests
Build 33559: arc lint + arc unit