Fix an initialization issue in VectorTree
ClosedPublic
Actions

Authored by epriestley on May 4 2020, 10:48 PM.

Details

Reviewers: None
Maniphest Tasks: T13520: Update the diff table of contents for moved files, long paths, etc
Commits: rARC22363974e2e0: (stable) Promote 2020 Week 18
rARCfb3e4014fc92: (stable) Fix an initialization issue in VectorTree
rARC6937d389472d: Fix an initialization issue in VectorTree

Summary

Ref T13520. In unusual cases where there are no changes in a changeset list (e.g., empty commits) we can fatal when trying to iterate over an empty list of vectors.

Test Plan

Created an empty commit.
Used "git show | pbcopy" to create a diff from it.
Viewed it in the web UI.
Before: fatal when iterating on null.
After: clean page.

Diff Detail

Repository

rARC Arcanist

Branch

vtree1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24356
Build 33553: Run Core Tests
Build 33552: arc lint + arc unit

Event Timeline

epriestley created this revision.May 4 2020, 10:48 PM

Harbormaster completed remote builds in B24356: Diff 50540.May 4 2020, 10:48 PM

epriestley requested review of this revision.May 4 2020, 10:48 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 10:50 PM

Closed by commit rARC6937d389472d: Fix an initialization issue in VectorTree (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC6937d389472d: Fix an initialization issue in VectorTree.

epriestley added a commit: rARCfb3e4014fc92: (stable) Fix an initialization issue in VectorTree.

epriestley added a commit: rARC22363974e2e0: (stable) Promote 2020 Week 18.May 8 2020, 9:20 PM

Revision Contents
Changeset List

Path

Size

src/

difference/

ArcanistDiffVectorTree.php

2 lines

Diff 50540

View Options

src/difference/ArcanistDiffVectorTree.php

Fix an initialization issue in VectorTreeClosedPublicActions