Page MenuHomePhabricator

Fix an initialization issue in VectorTree
ClosedPublic

Authored by epriestley on May 4 2020, 10:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 19 2024, 5:33 AM
Unknown Object (File)
Feb 16 2024, 12:11 AM
Unknown Object (File)
Feb 14 2024, 12:36 PM
Unknown Object (File)
Feb 8 2024, 9:41 AM
Unknown Object (File)
Feb 6 2024, 12:38 AM
Unknown Object (File)
Dec 29 2023, 4:19 AM
Unknown Object (File)
Dec 27 2023, 1:23 PM
Unknown Object (File)
Dec 27 2023, 7:38 AM
Subscribers
None

Details

Summary

Ref T13520. In unusual cases where there are no changes in a changeset list (e.g., empty commits) we can fatal when trying to iterate over an empty list of vectors.

Test Plan
  • Created an empty commit.
  • Used "git show | pbcopy" to create a diff from it.
  • Viewed it in the web UI.
  • Before: fatal when iterating on null.
  • After: clean page.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable