Differential D21217

When loading a page with inlines, don't select/focus inlines which we immediately upgrade to "editing"
ClosedPublic
Actions

Authored by epriestley on May 4 2020, 8:37 PM.

Tags

None

Referenced Files

	F13172446: D21217.id50530.diff
	Tue, May 7, 3:39 PM

	Unknown Object (File)
	Sun, May 5, 8:42 PM

	Unknown Object (File)
	Thu, May 2, 4:56 PM

	Unknown Object (File)
	Sat, Apr 27, 6:12 PM

	Unknown Object (File)
	Fri, Apr 26, 4:08 AM

	Unknown Object (File)
	Wed, Apr 24, 11:05 PM

	Unknown Object (File)
	Tue, Apr 16, 10:04 PM

	Unknown Object (File)
	Tue, Apr 16, 5:10 PM

View All 67 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13513: Make schema changes to inlines to prepare for new inline features
Commits: rP3a76248071eb: When loading a page with inlines, don't select/focus inlines which we…

Summary

Ref T13513. This is a bit clumsy, but the cleanest way to implement "isEditing" inlines today is to send them down as normal inlines and then simulate clicking "edit" on them.

When we do, don't focus the resulting editor: focusing it makes the page scroll around and highlight things in essentially random order as the editors load in.

Test Plan

Reloaded a page with some open editors, wasn't scrolled to them.

Diff Detail

Repository

Branch

focus1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24347
Build 33540: Run Core Tests
Build 33539: arc lint + arc unit

Event Timeline

epriestley created this revision.May 4 2020, 8:37 PM

Harbormaster completed remote builds in B24347: Diff 50530.May 4 2020, 8:38 PM

epriestley requested review of this revision.May 4 2020, 8:38 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 10:15 PM

Closed by commit rP3a76248071eb: When loading a page with inlines, don't select/focus inlines which we… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP3a76248071eb: When loading a page with inlines, don't select/focus inlines which we….

Revision Contents
Changeset List

Path

Size

resources/

celerity/

webroot/

rsrc/

js/

application/

diff/

36 lines

Diff 50530

resources/celerity/map.php

Loading...

webroot/rsrc/js/application/diff/DiffInline.js

Loading...