Page MenuHomePhabricator

When loading a page with inlines, don't select/focus inlines which we immediately upgrade to "editing"
ClosedPublic

Authored by epriestley on May 4 2020, 8:37 PM.
Tags
None
Referenced Files
F15503493: D21217.id50530.diff
Mon, Apr 14, 10:16 AM
F15484419: D21217.diff
Wed, Apr 9, 6:11 PM
F15466614: D21217.id50533.diff
Thu, Apr 3, 7:36 AM
F15443736: D21217.id.diff
Thu, Mar 27, 5:54 AM
F15434039: D21217.id.diff
Tue, Mar 25, 1:40 AM
F15426800: D21217.diff
Sun, Mar 23, 10:53 AM
F15407324: D21217.diff
Tue, Mar 18, 4:54 PM
F15333503: D21217.diff
Mar 8 2025, 2:40 AM
Subscribers
None

Details

Summary

Ref T13513. This is a bit clumsy, but the cleanest way to implement "isEditing" inlines today is to send them down as normal inlines and then simulate clicking "edit" on them.

When we do, don't focus the resulting editor: focusing it makes the page scroll around and highlight things in essentially random order as the editors load in.

Test Plan

Reloaded a page with some open editors, wasn't scrolled to them.

Diff Detail

Repository
rP Phabricator
Branch
focus1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24347
Build 33540: Run Core Tests
Build 33539: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 10:15 PM
This revision was automatically updated to reflect the committed changes.