Page MenuHomePhabricator

When loading a page with inlines, don't select/focus inlines which we immediately upgrade to "editing"
ClosedPublic

Authored by epriestley on May 4 2020, 8:37 PM.
Tags
None
Referenced Files
F14081103: D21217.diff
Fri, Nov 22, 6:26 PM
Unknown Object (File)
Tue, Oct 29, 5:19 AM
Unknown Object (File)
Oct 20 2024, 2:37 AM
Unknown Object (File)
Oct 13 2024, 9:44 AM
Unknown Object (File)
Oct 4 2024, 1:44 PM
Unknown Object (File)
Sep 8 2024, 10:32 AM
Unknown Object (File)
Sep 6 2024, 7:28 AM
Unknown Object (File)
Sep 4 2024, 8:03 PM
Subscribers
None

Details

Summary

Ref T13513. This is a bit clumsy, but the cleanest way to implement "isEditing" inlines today is to send them down as normal inlines and then simulate clicking "edit" on them.

When we do, don't focus the resulting editor: focusing it makes the page scroll around and highlight things in essentially random order as the editors load in.

Test Plan

Reloaded a page with some open editors, wasn't scrolled to them.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 10:15 PM
This revision was automatically updated to reflect the committed changes.