Page MenuHomePhabricator

Save drafts for inline comments currently being edited
ClosedPublic

Authored by epriestley on May 4 2020, 7:44 PM.
Tags
None
Referenced Files
F19822572: D21216.id50529.diff
Sat, Mar 7, 6:36 AM
F19771820: D21216.id50519.diff
Fri, Feb 20, 10:17 AM
F19771819: D21216.id50519.diff
Fri, Feb 20, 10:07 AM
F19715625: D21216.id50519.diff
Thu, Feb 12, 6:42 AM
F19614547: D21216.id50529.diff
Feb 3 2026, 10:06 PM
F19589512: D21216.id50519.diff
Feb 2 2026, 10:45 AM
F18936339: D21216.diff
Nov 10 2025, 8:05 PM
F18857519: D21216.id.diff
Nov 1 2025, 3:49 PM
Subscribers
None

Details

Summary

Ref T13513. As users type text into inline comments, save the comment state as a draft on the server.

This has some rough edges, particularly around previews, but mostly works. See T13513 for notes.

Test Plan

Started an inline, typed some text, waited a second, reloaded the page, saw an editing inline with the saved text.

Diff Detail

Repository
rP Phabricator
Branch
inline10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24336
Build 33528: Run Core Tests
Build 33527: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 8:19 PM
This revision was automatically updated to reflect the committed changes.