Page MenuHomePhabricator

Save drafts for inline comments currently being edited
ClosedPublic

Authored by epriestley on May 4 2020, 7:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 9:13 AM
Unknown Object (File)
Sun, Feb 9, 9:12 AM
Unknown Object (File)
Sun, Feb 9, 9:12 AM
Unknown Object (File)
Thu, Feb 6, 7:23 PM
Unknown Object (File)
Wed, Feb 5, 1:59 PM
Unknown Object (File)
Tue, Feb 4, 5:26 PM
Unknown Object (File)
Sat, Jan 25, 7:31 AM
Unknown Object (File)
Sat, Jan 25, 7:31 AM
Subscribers
None

Details

Summary

Ref T13513. As users type text into inline comments, save the comment state as a draft on the server.

This has some rough edges, particularly around previews, but mostly works. See T13513 for notes.

Test Plan

Started an inline, typed some text, waited a second, reloaded the page, saw an editing inline with the saved text.

Diff Detail

Repository
rP Phabricator
Branch
inline10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24336
Build 33528: Run Core Tests
Build 33527: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 8:19 PM
This revision was automatically updated to reflect the committed changes.