Page MenuHomePhabricator

Save drafts for inline comments currently being edited
ClosedPublic

Authored by epriestley on May 4 2020, 7:44 PM.
Tags
None
Referenced Files
F18936339: D21216.diff
Nov 10 2025, 8:05 PM
F18857519: D21216.id.diff
Nov 1 2025, 3:49 PM
F18835240: D21216.diff
Oct 26 2025, 2:27 PM
F18780472: D21216.id50519.diff
Oct 12 2025, 4:30 PM
F18722279: D21216.id50529.diff
Sep 29 2025, 10:28 PM
F18471243: D21216.diff
Sep 2 2025, 7:02 PM
F18112313: D21216.diff
Aug 12 2025, 4:21 PM
F18101082: D21216.id.diff
Aug 9 2025, 12:19 PM
Subscribers
None

Details

Summary

Ref T13513. As users type text into inline comments, save the comment state as a draft on the server.

This has some rough edges, particularly around previews, but mostly works. See T13513 for notes.

Test Plan

Started an inline, typed some text, waited a second, reloaded the page, saw an editing inline with the saved text.

Diff Detail

Repository
rP Phabricator
Branch
inline10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24336
Build 33528: Run Core Tests
Build 33527: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 8:19 PM
This revision was automatically updated to reflect the committed changes.