Page MenuHomePhabricator

Save drafts for inline comments currently being edited
ClosedPublic

Authored by epriestley on May 4 2020, 7:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 3:54 PM
Unknown Object (File)
Sun, Apr 28, 3:59 PM
Unknown Object (File)
Fri, Apr 26, 3:03 AM
Unknown Object (File)
Thu, Apr 25, 3:31 PM
Unknown Object (File)
Thu, Apr 25, 12:23 PM
Unknown Object (File)
Wed, Apr 24, 11:49 PM
Unknown Object (File)
Fri, Apr 12, 2:55 PM
Unknown Object (File)
Thu, Apr 11, 8:02 AM
Subscribers
None

Details

Summary

Ref T13513. As users type text into inline comments, save the comment state as a draft on the server.

This has some rough edges, particularly around previews, but mostly works. See T13513 for notes.

Test Plan

Started an inline, typed some text, waited a second, reloaded the page, saw an editing inline with the saved text.

Diff Detail

Repository
rP Phabricator
Branch
inline10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24336
Build 33528: Run Core Tests
Build 33527: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 8:19 PM
This revision was automatically updated to reflect the committed changes.