Page MenuHomePhabricator

Fix an issue where the "%%%" parser could match too many lines in unterminated blocks
ClosedPublic

Authored by epriestley on May 3 2020, 4:18 PM.
Tags
None
Referenced Files
F15465404: D21208.id.diff
Wed, Apr 2, 6:16 PM
F15464284: D21208.id50505.diff
Wed, Apr 2, 8:10 AM
F15463975: D21208.id50504.diff
Wed, Apr 2, 5:11 AM
F15462503: D21208.id.diff
Tue, Apr 1, 3:30 PM
F15458817: D21208.diff
Mon, Mar 31, 7:39 AM
F15429013: D21208.id50504.diff
Mon, Mar 24, 12:02 AM
F15428829: D21208.diff
Sun, Mar 23, 10:37 PM
F15400253: D21208.id.diff
Mon, Mar 17, 10:36 AM
Subscribers
None

Details

Summary

Fixes T13530. The block parser could match too many lines in an unterminated "%%%" literal block. Adjust the logic to stop doing this (and hopefully be a little easier to read).

Test Plan

Added a failing test, made it pass.

Diff Detail

Repository
rP Phabricator
Branch
literal1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24321
Build 33505: Run Core Tests
Build 33504: arc lint + arc unit