Page MenuHomePhabricator

Fix an issue where the "%%%" parser could match too many lines in unterminated blocks
ClosedPublic

Authored by epriestley on May 3 2020, 4:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 10:08 AM
Unknown Object (File)
Sat, Nov 9, 4:04 PM
Unknown Object (File)
Oct 23 2024, 10:29 AM
Unknown Object (File)
Oct 22 2024, 9:35 PM
Unknown Object (File)
Oct 16 2024, 12:20 PM
Unknown Object (File)
Sep 4 2024, 1:47 PM
Unknown Object (File)
Sep 3 2024, 11:19 AM
Unknown Object (File)
Sep 3 2024, 11:19 AM
Subscribers
None

Details

Summary

Fixes T13530. The block parser could match too many lines in an unterminated "%%%" literal block. Adjust the logic to stop doing this (and hopefully be a little easier to read).

Test Plan

Added a failing test, made it pass.

Diff Detail

Repository
rP Phabricator
Branch
literal1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24321
Build 33505: Run Core Tests
Build 33504: arc lint + arc unit