Page MenuHomePhabricator

Fix an issue where the "%%%" parser could match too many lines in unterminated blocks
ClosedPublic

Authored by epriestley on May 3 2020, 4:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 25 2025, 6:53 AM
Unknown Object (File)
May 7 2025, 4:15 AM
Unknown Object (File)
Apr 21 2025, 7:09 PM
Unknown Object (File)
Apr 6 2025, 9:43 AM
Unknown Object (File)
Apr 2 2025, 6:16 PM
Unknown Object (File)
Apr 2 2025, 8:10 AM
Unknown Object (File)
Apr 2 2025, 5:11 AM
Unknown Object (File)
Apr 1 2025, 3:30 PM
Subscribers
None

Details

Summary

Fixes T13530. The block parser could match too many lines in an unterminated "%%%" literal block. Adjust the logic to stop doing this (and hopefully be a little easier to read).

Test Plan

Added a failing test, made it pass.

Diff Detail

Repository
rP Phabricator
Branch
literal1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24321
Build 33505: Run Core Tests
Build 33504: arc lint + arc unit