Page MenuHomePhabricator

Fix an issue where the "%%%" parser could match too many lines in unterminated blocks
ClosedPublic

Authored by epriestley on May 3 2020, 4:18 PM.
Tags
None
Referenced Files
F18898701: D21208.id.diff
Fri, Nov 7, 7:06 PM
F18715834: D21208.id.diff
Sep 29 2025, 10:47 AM
F18658378: D21208.id50505.diff
Sep 23 2025, 6:09 AM
F18645160: D21208.diff
Sep 19 2025, 7:02 AM
F18577489: D21208.diff
Sep 10 2025, 7:08 PM
F18444284: D21208.id.diff
Aug 31 2025, 7:34 PM
F18412513: D21208.diff
Aug 30 2025, 6:42 AM
F18082897: D21208.id50504.diff
Aug 5 2025, 7:51 AM
Subscribers
None

Details

Summary

Fixes T13530. The block parser could match too many lines in an unterminated "%%%" literal block. Adjust the logic to stop doing this (and hopefully be a little easier to read).

Test Plan

Added a failing test, made it pass.

Diff Detail

Repository
rP Phabricator
Branch
literal1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24321
Build 33505: Run Core Tests
Build 33504: arc lint + arc unit