Differential D21178

Fix an invalid index access for synthetic lint inline comments from Harbormaster
ClosedPublic
Actions

Authored by epriestley on Apr 27 2020, 9:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 9, 9:07 AM

	Unknown Object (File)
	Sun, Feb 9, 9:07 AM

	Unknown Object (File)
	Sun, Feb 9, 9:07 AM

	Unknown Object (File)
	Fri, Jan 31, 1:39 PM

	Unknown Object (File)
	Sat, Jan 25, 7:22 AM

	Unknown Object (File)
	Sat, Jan 25, 7:22 AM

	Unknown Object (File)
	Sat, Jan 25, 7:22 AM

	Unknown Object (File)
	Jan 21 2025, 12:00 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13524: "Undefined index" exception in ChangesetParser while viewing diffs
Commits: rPe17c49699309: (stable) Fix an invalid index access for synthetic lint inline comments from…
rPaa20faeaa5d1: Fix an invalid index access for synthetic lint inline comments from Harbormaster

Summary

Ref T13524. If a Harbormaster lint message has no line number (which is permitted), we try to access an invalid index here. This is an exception after D21044.

Treat comments with no line number as unchanged. These comments do not have "ghost" behavior and do not port across diffs.

Test Plan

Used "harbormaster.sendmessage" to submit lint with no line number on a changeset.
Viewed changeset.
- Before patch: "Undefined index: <null>" error.
- After patch: Clean changeset with lint message.

Screen Shot 2020-04-27 at 2.17.38 PM.png (236×856 px, 18 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 27 2020, 9:18 PM

Harbormaster completed remote builds in B24251: Diff 50432.Apr 27 2020, 9:19 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 27 2020, 9:19 PM

epriestley requested review of this revision.

Closed by commit rPaa20faeaa5d1: Fix an invalid index access for synthetic lint inline comments from Harbormaster (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPaa20faeaa5d1: Fix an invalid index access for synthetic lint inline comments from Harbormaster.

epriestley added a commit: rPe17c49699309: (stable) Fix an invalid index access for synthetic lint inline comments from….

epriestley mentioned this in D18302: Fix "undefined index" error in Differential changeset parser.Mar 17 2021, 7:31 PM

epriestley mentioned this in T8591: Undefined index in changeset parser.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

parser/

DifferentialChangesetParser.php

12 lines

Diff 50433

src/applications/differential/parser/DifferentialChangesetParser.php

Loading...